[Pkg-salt-team] Uploaded repository - some issues remain

[Joe Healy]

On Mon, Apr 8, 2013 at 8:19 PM, Andrii Senkovych
<jolly_roger at itblog.org.ua> wrote:
> Guys,
>
> I see you are working on new version right now. Since you have quite
> intensive dialog, I'd better nor interfere until you are finished. If
> there's a possibility, I'd commit some things too, but perhaps I'll
> make some package review for now until you are satisfied with your
> work.

I'm happy with either input - I feel between Franklin and I it is a
little like the blind leading the blind.

>
> Please use lintian --pedantic to check all warnings.

Will do

>
> I have pushed some more changes to a separate branch[1]. You might
> want to review them and incorporate into master branch fully or
> partially. New changes will appear in that branch as well. Current
> lintian output for this branch is:

They are some great ideas. I've recently been pushing to a cleaner
repo (without the 70211f8855a commit).

The url is git+ssh://username@git.debian.org/git/pkg-salt/salt.git

I'm not fussed which one we go forwards with, but this new one is
slightly cleaner, but doesn't have your bits in it.

> $ lintian --pedantic salt_0.14.0-1_amd64.changes
> P: salt-minion: no-upstream-changelog
> P: salt-master: no-upstream-changelog
> P: salt-doc: no-upstream-changelog
> P: salt-syndic: no-upstream-changelog
> P: salt-common: no-upstream-changelog
> W: salt-common: manpage-has-errors-from-man
> usr/share/man/man7/salt.7.gz 2052: warning [p 22, 4.3i, div `3tbd2,2',
> 0.0i]: can't break line
>
> Currently I could not fix the manual page. That line corresponds to
> the data in the table that is by all logic should not be breakable
> into several lines because it's a single token. Maybe we should
> suppress this warning.
>
> I'm going to work on the following tasks:
> 1) Run tests during build.
> 2) Substitute manual javascript removal with dh_sphinxdoc.
> 3) Try pybuild

I don't know pybuild, but the others seem really useful.


>
> I'll notify you if something new appears. Here are some details:
>
> It is possible to run salt tests during build process, however there
> are some tests failing since they run from fakeroot'ed unprivileged
> user (build log attached). I believe it is possible to skip these
> tests (by applying quilt patch) or ask upstream to fix them. Note:
> this would also introduce new build-deps: python-mako and
> python-unittest2 for python < 2.7

This sounds good.
>
> Maybe you'd like to test against all supported python versions. You
> can always detect those with pyversions utility. Here's a snippet that
> will enable running tests during package building:
>
> ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
> override_dh_auto_test:
>     python setup.py test
> endif

So does this.

>
> Another thing I've spotted is manual removal of javascript files as
> well. I'm not aware if you have tried to use dh_sphinxdoc but you
> might want to use it. It's pretty simple:
>
> %:
>      dh $@ --wih python2,bash-completion,sphinxdoc

This originates from before our time and currently beyond our
understanding. This looks really interesting. How does one learn about
the things you can put at the end of the dh line?

Thanks very much for your feedback. It is really good to see where we
should be pushing this.

I think I need to improve my git cherrypicking skills to work with your branch.

Thanks,

Joe