[Pkg-salt-team] Bug#698898: Bug#698898: Bug#698898: Bug#698898: certificate file locations

Andrii Senkovych jolly_roger at itblog.org.ua
Wed Apr 10 11:01:59 UTC 2013


2013/4/10 Joe Healy <joehealy at gmail.com>:
> We don't actually need to change the default location via quilt as the
> postinst script will change it. But it is probably more obvious for
> newcomers and others to have the patch there. Downside is the work is
> done in two places - but, in time we could probably delete the script
> once we were confident there were not any very early versions out
> there...

I'd use patches+postinst scripts anyway.

Patches declare what is done for why. DEP3[1] shows how to write
patches that upstream refused to accept (i.e. they are
Debian-specific). Postinst script should be written to work correctly
any number of times anyway (according to Debian policy[2]), so i doubt
there would be any problems if we leave this code for a reasonable
long time. But this is worth noting in README.Debian

2013/4/10 Joe Healy <joehealy at gmail.com>:
> The other thing that feels a little odd is running a search and
> replace on a users config file, but anything else seems worse.

I'd also mention conf.d directories as well (e.g. /etc/salt/minion.d
and similar in other binary packages, if not modified by default).

I don't see a problem here. Sure it would be better to parse config
instead of using sed/grep/awk or other tools, since it's YAML. But
this should be a top-level item anyway, so I hope there would be no
problems.

  [1]: http://dep.debian.net/deps/dep3/
  [2]: http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html



More information about the pkg-salt-team mailing list