[Pkg-samba-maint] Bug#454112: Cleaning out winbindd PID file

[Steve Langasek]

On Mon, Apr 14, 2008 at 05:34:03PM +0200, Christian Perrier wrote:
> tags 454112 patch
> thanks

> As correctly stated in that bug report, winbindd doesn't clean out its
> PID file when stopped.

> Actually, neither nmbd nor smbd do....but we tricked the removal in
> the init script.

> As a consequence, I propose the attached patch as a fix to out
> winbind.init script.

I don't think this correctly handles the case where start-stop-daemon
/fails/; we don't want to remove the pid file in that case, we want to leave
it in place since that indicates the daemon is still running for some
reason.

Looking at it, the current samba package probably also does the wrong thing
on failure... probably a bug introduced with the LSBing of the init script.
:/  But that's a separate bug, no need to introduce a bug in the winbind
package too.

> It also includes minor consistency change with the samba.init script
> (use log_progress_msg after log_daemon_msg).

This is a false consistency which will do the wrong thing on Ubuntu (and on
Debian, if we ever adopt Ubuntu's pretty-printing LSB scripts). 
log_progress_msg is used in /etc/init.d/samba only because there are two
daemons to be started/stopped; when there's only one, the two-argument form
of log_daemon_msg is preferable.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org