[Pkg-samba-maint] Bug#488275: Bug#488275: samba and winbind: initscript miss 'status' option
tim at kumina.nl
Tue Jul 1 08:34:09 UTC 2008
Op 30-jun-2008, om 23:14 heeft Steve Langasek het volgende geschreven:
> Here comes the criticism ;)
I prefer the term "constructive remarks" ;-)
> So the right way to do this is to look at the PID files themselves
> check their contents, and verify that those processes are still
True that. I'll try your code today and report back with a proper diff.
> Note that procps is required for this functionality to work,
> because of the
> use of ps. I don't know that a dependency is actually warranted,
> since this
> is optional functionality; anyway, procps is Priority: required, so
> it will
> always be present in practice.
Should the script check for the existence of /bin/ps? Or should I
just leave it as it is?
> I don't have a problem with the 'echo' statements myself, though I
> do object
> to the use of exclamation marks. :)
Uh... woops? :) Will replace them.
> Well, this means that no meaningful status will be returned if one
> of the
> daemons is running but the other is not. Concretely, this means it
> return useful status in the event that smbd is started out of inetd
> (RUN_MODE=inetd), or that 'disable netbios' is set, causing nmbd to
> not be
Checking /etc/default/samba is easy, but I'm not sure if I can
reliably check for the 'disable netbios' option. Any hints on how to
> I think it would be better to first fix winbind to use a proper PID
> then use code similar to that in the smbd/nmbd case.
I'll spend some time today to see if I can fix that. I guess the --
make-pidfile option from start-stop-daemon should be used. Will let
you know when I come up with something that works.
Met vriendelijke groet,
kvk nr 14095795
More information about the Pkg-samba-maint