[Pkg-samba-maint] About smbtar-bashism.patch

Christian Perrier bubulle at debian.org
Tue Jul 1 17:47:29 UTC 2008

Jelmer committed a patch in samba package's trunk:

Goal: Avoid using bashism in smbtar

Status wrt upstream: Debian-specific.

Fixes: #486056

Author: Jelmer Vernooij <jelmer at samba.org>


Index: samba/source/script/smbtar
--- samba/source/script/smbtar  (Revision 1955)
+++ samba/source/script/smbtar  (Arbeitskopie)
@@ -151,7 +151,7 @@
 if [ -z "$verbose" ]; then
       echo "server    is $server"
 #     echo "share     is $service"
-      echo "share     is $service\\$cdcmd"
+      printf "share     is %s\\%s\n" "$service" "$cdcmd"
       echo "tar args  is $tarargs"
 #     echo "password  is $password"  # passwords should never be sent to screen
       echo "tape      is $tapefile"

I think this patch is *not* Debian-specific and could be forwarded


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20080701/0e8f5434/attachment.pgp 

More information about the Pkg-samba-maint mailing list