[Pkg-samba-maint] Bug#563729: Users can not rename or delete files although creating new files works

[Andreas Gredler]

Package: samba
Version: 2:3.4.0-2+b1
Severity: important

After an upgrade of a Samba PDC from etch to lenny I've found a really
strange bug. On one of the shares users were still able to create
files but not to rename or delete them again. It seems that this only
happens in conjuntion with the "force group" option! When using
smbclient there's no such problem.
Found somebody else having the same problem on MacOS:
http://lists.apple.com/archives/macos-x-server/2008/Jan/msg00759.html
The solution worked for me, too: Set "acl check permissions = no" for
the share.

I've tested with the following versions in debian:

Etch: 3.0.24 -> no problem
Lenny: 3.2.5 -> bug reproducable
Sid: 3.4.3 -> no problem

Steps to reproduce:

[Test]
        comment = Test
        path = /srv/data/testdir
        public = no
        writable = yes
        create mask = 0770
        directory mask = 0770
        force group = groupA
        force unknown acl user = yes
        inherit acls = yes
        inherit permissions = yes
        map acl inherit = yes
        acl check permissions = yes

groupadd groupA
groupadd groupB
adduser --force-badname --ingroup groupA userA
adduser --force-badname --ingroup groupB userB
smbpasswd -a userB

mount /dev/sdb1 /srv/data/
mkdir testdir
chown userA:groupA testdir
chmod 0770 testdir
setfacl -m g:groupB:rwx testdir
setfacl -m g::--- testdir

WinXP client -> new document -> try to delete/rename -> fails
Change samba config -> acl check permissions = no -> works

Will also post on the samba mailing list since this bug might affect a couple
of people when upgrading to lenny.

greets Andreas "Jimmy" Gredler