[Pkg-samba-maint] Bug#249873: Bug#249873: Bug#249873: Updated patch

[Christian PERRIER]

I finally came up with something completely different.

The main problem of fhs-filespaths.patch is indeed that we replace
lp_private_dir() by get_dyn_STATEDIR(), so by the location of "state
directory" *that is defined at compile-time*.

Indeed, it's quite logical to have secrets.tdb and passdb.tdb located
in /var/lib/samba, namely the "state directory" and I think that
upstream is indeed wrong in putting them in "private dir" as they mean
that the files there are configuration file that can be directly
managed by the local admin (which secrets.tdb and passdb.tdb are NOT).

So, the right location for the two files is "state directory" but for
this to work as expected AND be configurable, lp_private_dir() should
be replaced by lp_statedir() calls. lp_statedir() does obey the "state
directory" configuration option, therefore the files' location will be
configurable.

So, I finally changed the patch and added a small modification to
smb.conf(5) to explain what we're doing in the Debian package.

Another action is probably to convince upstream to reconsider what
should go to "private dir" and what should go to "state directory"
(yes the two options names are NOT consistent).But changing this *is*
where we'll need to handle transitions.

Unless I'm mistaken somewhere, the attached patch does NOT change the
file locations in the Debian package BUT makes them configurable.

I'll commit this change : it can of course be easily reverted in case
I'm wrong somewhere.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 249873.patch
Type: text/x-diff
Size: 3256 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20120508/a1e0f551/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20120508/a1e0f551/attachment.pgp>