[Pkg-samba-maint] ldb so bump?

[Andrew Bartlett]

On Mon, 2019-09-16 at 10:20 +0200, Mathieu Parent wrote:
> Le lun. 16 sept. 2019 à 08:38, Andrew Bartlett <abartlet at samba.org> a
> écrit :
> > 
> > On Sun, 2019-09-15 at 18:12 +0200, Mathieu Parent wrote:
> > > Hello Andrew,
> > > 
> > > I'm preparing samba 4.11 debian package including ldb 2.0.7.
> > > 
> > > I'm wondering: Does this needs a so bump (libldb2)? the commit
> > > is:
> > > 
> > > commit 15d1ecdca6a4fbceddefd7ef4b8a9b912c067207
> > > Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
> > > Date:   Wed Mar 20 13:52:16 2019 +1300
> > > 
> > >     ldb: version 2.0.0
> > > 
> > >     * Version bump for adding index_format_fn to the schema
> > > syntax
> > > structure.
> > >     * Range index support added, allowing <= and >= operations to
> > > be
> > > indexed
> > >     * Improved reindex performance by setting the in-memory TDB
> > > hash
> > > size correctly
> > > 
> > >     Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
> > >     Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > >     Reviewed-by: Garming Sam <garming at catalyst.net.nz>
> > > 
> > > Cheers
> > 
> > ldb bumps SO with the package version.  I tried to split this up
> > but
> > wasn't successful.
> > 
> > Furthermore, a strict reading of the ABI rules meant that a change
> > in
> > the public structure, even when we know that nobody other than
> > Samba
> > uses it, means we have to bump the SO version.
> 
> sssd builds against libldb-dev. I don't know if they are impacted by
> the schema change, but at least they will be impacted by the so bump.

No, sssd does not use the changed routines, nor the new pack format (as
it is tied to a feature, GUID-based indexing, that sssd does not
activate). 

I say this because I checked the code before we did the work.

Andrew Bartlett

-- 
Andrew Bartlett                       https://samba.org/~abartlet/
Authentication Developer, Samba Team  https://samba.org
Samba Developer, Catalyst IT          
https://catalyst.net.nz/services/samba