[Pkg-samba-maint] [Pkg-sssd-devel] ldb so bump?

[Timo Aaltonen]

On 16.9.2019 11.20, Mathieu Parent wrote:
> Le lun. 16 sept. 2019 à 08:38, Andrew Bartlett <abartlet at samba.org> a écrit :
>>
>> On Sun, 2019-09-15 at 18:12 +0200, Mathieu Parent wrote:
>>> Hello Andrew,
>>>
>>> I'm preparing samba 4.11 debian package including ldb 2.0.7.
>>>
>>> I'm wondering: Does this needs a so bump (libldb2)? the commit is:
>>>
>>> commit 15d1ecdca6a4fbceddefd7ef4b8a9b912c067207
>>> Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
>>> Date:   Wed Mar 20 13:52:16 2019 +1300
>>>
>>>     ldb: version 2.0.0
>>>
>>>     * Version bump for adding index_format_fn to the schema syntax
>>> structure.
>>>     * Range index support added, allowing <= and >= operations to be
>>> indexed
>>>     * Improved reindex performance by setting the in-memory TDB hash
>>> size correctly
>>>
>>>     Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
>>>     Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>>     Reviewed-by: Garming Sam <garming at catalyst.net.nz>
>>>
>>> Cheers
>>
>> ldb bumps SO with the package version.  I tried to split this up but
>> wasn't successful.
>>
>> Furthermore, a strict reading of the ABI rules meant that a change in
>> the public structure, even when we know that nobody other than Samba
>> uses it, means we have to bump the SO version.
> 
> sssd builds against libldb-dev. I don't know if they are impacted by
> the schema change, but at least they will be impacted by the so bump.
> 
> CC-ing them.
> 
>>
>> Finally, and tangentially related, I would strongly recommend just
>> building ldb from the samba tarball, and not paying any attention to
>> the distinct ldb tarbals.  If you need me to prepare a patch to do this
>> as part of the main build I can to that for you, but I'm hoping you can
>> just install it during the build.
> 
> SSSd team, any comments on this?

Fine by me, assuming there's still going to be a libldb-dev so that sssd
builds.



-- 
t