[Pkg-samba-maint] Bug#972912: Bug#972912: Incorrect fix to bug

[Sven Mueller]

Ack, merge request created.
I had already built ldb with the patch for both unstable and the
environment I ran into issues due to the symbols check and also rebuilt
samba in both afterwards. Both built fine and at least basic functionality
tests also worked fine.

Am Fr., 8. Jan. 2021 um 13:33 Uhr schrieb Mathieu Parent <
math.parent at gmail.com>:

> Le lun. 21 déc. 2020 à 16:06, Sven Mueller <sven.mueller72 at gmail.com> a
> écrit :
> >
> > Well, turns out that apparently nobody else bothers with a .symbols file
> for Python extensions. I looked at the packages for samba, numpy, mypy and
> python-stdlib-extensions. And if the Python maintainers themselves don't do
> it, you probably shouldn't.
> >
> > I attached a diff to remove the relevant file and the setup for it. I
> also added some verbosity to the stuff debhelper does (I find it harder to
> debug build issues without it).
> > I verified that except for this symbols file going away, nothing else
> changed. (Most notable, the main libldb-dev package still looks the same.)
> - Verified via diffoscope which only showed expected changes (timestamps,
> mostly)
> >
> > I'll see if I can turn it into a pull request on Salsa, but my git-foo
> is weaker than it probably should be, so feel free to just apply my patch
> yourself.
> > If I create a pull request, should that include an update to
> debian/changelog?
>
> Hello, just a quick note that I won't work on this for bullseye. If
> you can propose a MR in salsa and test that samba builds and works,
> I'll happily review it.
>
> Regards
> --
> Mathieu Parent
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-samba-maint/attachments/20210108/acea836f/attachment.html>