[Pkg-samba-maint] master branch review
Mathieu Parent
math.parent at gmail.com
Sat Apr 2 09:39:38 BST 2022
Hi Michael,
I've reviewed the master branch up to e5eaefa1775fe841a5e0e81f2c25045d7c95c2bf
You've done an amazing job! The package is in much better shape now.
A few questions:
- 9ab2a406b2972e18e1568963ecf4fe949d5d4921 "d/rules: specify the
package name for dh_installpam". The result is that the pam config is
kept in samba-common?
- 9d27f1aa68240921451a0b27d19671c5b13c6f91 "fix long-standing issues
in shlibdeps handling". Wow! I don't understand completely, but
thanks!
- Have you tested building sssd with it?
Appart from that, some of the patches need to be forwarded, but you
already know that.
IMO, the package is ready to be uploaded to experimental.
Regards
--
Mathieu Parent
More information about the Pkg-samba-maint
mailing list