[Pkg-samba-maint] "fix" for #221618 - LARGEFILE_SOURCE in libsmbclient.h

Michael Tokarev mjt at tls.msk.ru
Sun Apr 3 08:09:03 BST 2022


03.04.2022 09:37, Mathieu Parent wrote:
> On Sat, Apr 2, 2022 at 7:54 PM Michael Tokarev <mjt at tls.msk.ru> wrote:
..
>> +_Static_assert(sizeof(off_t) >= 8, /* C11 keyword */
>> + "libsmbclient.h needs LFS (-D_FILE_OFFSET_BITS=64) on this platform");
>> +
>>    #define SMBC_BASE_FD        10000 /* smallest file descriptor returned */
> 
> Yes, this is better now.

It still does have a possible issue, - I described it in the patch
description.  Namely, the client software (a user of libsmbclient.h)
might use smbc_* functions which does not have off_t arguments, --
these does not require _F_O_B to be 64. After this change, these
programs will start to FTBFS.

Anyway, this is an interesting issue :)

/mjt



More information about the Pkg-samba-maint mailing list