Bug#1011014: libsdl2-dev: double-promotion warning when including SDL_rect.h indirectly

[Manuel Bilderbeek]

Package: libsdl2-dev
Version: 2.0.22+dfsg-3
Severity: normal

Dear Maintainer,

   * What led up to the situation?

Update in testing to this version.

Our application openMSX compiles against SDL2 (see the Debian package). As of
the recent update of SDL2 in testing it generates many warnings during
compilation, in an SDL2 header file... for instance:

Compiling PluggableFactory.cc...
In file included from /usr/include/SDL2/SDL_video.h:33,
                 from /usr/include/SDL2/SDL_events.h:33,
                 from /usr/include/SDL2/SDL.h:41,
                 from src/input/Joystick.hh:9,
                 from src/PluggableFactory.cc:5:
/usr/include/SDL2/SDL_rect.h: In function ‘SDL_bool SDL_FRectEqualsEpsilon(const SDL_FRect*, const SDL_FRect*, float)’:
/usr/include/SDL2/SDL_rect.h:255:37: warning: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Wdouble-promotion]
  255 |             ((SDL_fabs(a->x - b->x) <= epsilon) &&
      |               ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/usr/include/SDL2/SDL_rect.h:256:36: warning: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Wdouble-promotion]
  256 |             (SDL_fabs(a->y - b->y) <= epsilon) &&
      |              ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/usr/include/SDL2/SDL_rect.h:257:36: warning: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Wdouble-promotion]
  257 |             (SDL_fabs(a->w - b->w) <= epsilon) &&
      |              ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/usr/include/SDL2/SDL_rect.h:258:36: warning: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Wdouble-promotion]
  258 |             (SDL_fabs(a->h - b->h) <= epsilon))))
      |              ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

This gives rather noisy output during compilation.

I hope someone can take a look at it.

Kind regards,
Manuel

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.17.0-1-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=nl_NL.UTF-8, LC_CTYPE=nl_NL.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libsdl2-dev depends on:
ii  libasound2-dev    1.2.6.1-2+b1
ii  libdbus-1-dev     1.14.0-1
ii  libegl1-mesa-dev  21.3.8-1
ii  libgl-dev         1.4.0-1
ii  libgles-dev       1.4.0-1
ii  libglu1-mesa-dev  9.0.2-1
ii  libibus-1.0-dev   1.5.26-4
ii  libpulse-dev      15.0+dfsg1-4
ii  libsdl2-2.0-0     2.0.22+dfsg-3
ii  libsndio-dev      1.8.1-1.1
ii  libudev-dev       250.4-1
ii  libwayland-dev    1.20.0-1
ii  libx11-dev        2:1.7.5-1
ii  libxcursor-dev    1:1.2.1-1
ii  libxext-dev       2:1.3.4-1
ii  libxi-dev         2:1.8-1
ii  libxinerama-dev   2:1.1.4-3
ii  libxkbcommon-dev  1.4.0-1
ii  libxrandr-dev     2:1.5.2-2+b1
ii  libxss-dev        1:1.2.3-1
ii  libxt-dev         1:1.2.1-1
ii  libxv-dev         2:1.0.11-1
ii  libxxf86vm-dev    1:1.1.4-1+b2

libsdl2-dev recommends no packages.

libsdl2-dev suggests no packages.

-- no debconf information