Bug#1011014: libsdl2-dev: double-promotion warning when including SDL_rect.h indirectly

[Simon McVittie]

Control: tags -1 + fixed-upstream

On Sun, 15 May 2022 at 12:25:59 +0200, Manuel Bilderbeek wrote:
> Our application openMSX compiles against SDL2 (see the Debian package). As of
> the recent update of SDL2 in testing it generates many warnings during
> compilation, in an SDL2 header file... for instance:
> 
> /usr/include/SDL2/SDL_rect.h: In function ‘SDL_bool SDL_FRectEqualsEpsilon(const SDL_FRect*, const SDL_FRect*, float)’:
> /usr/include/SDL2/SDL_rect.h:255:37: warning: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Wdouble-promotion]
>   255 |             ((SDL_fabs(a->x - b->x) <= epsilon) &&

Thanks, fixed upstream by <https://github.com/libsdl-org/SDL/issues/5691>.

(I have to wonder whether this warning is providing openMSX with a
practical benefit, though: these days even cheap embedded CPUs have a
double-precision FPU.)

    smcv