[pkg][dhcpig] ready for review

[phil at reseau-libre.net]

On 2017-06-23 10:23, Raphael Hertzog wrote:
> [ You need to stop putting into CC the
> pkg-security-team-bounces+phil=reseau-libre.net at lists.alioth.debian.org
> email address, I wonder how you manage that, it's only in the envelope
> from in theory... but I get mails about unknown bounces due to that ]

It's keeped when i do a reply-all through roundcube (i can only use a 
webmail just now). I'll check for it when replying.


> 
> The important part is to start with "0~", the part afterwards is 
> usually
> a date (so that we can do regular snapshots and have a linear increase 
> in
> version), sometimes with an additional git commit to make it clear what
> commit has been snapshotted.

Ok. I've updated the current version with timestamp.git<hashstart> as 
there is multiple commits timestamped that day.

> 
> 
> Then please indicate it in the patch headers, I want to see:
> Bug: https://github.com/.../issue/XXX
> or something like that (cf DEP-3 http://dep.debian.net/deps/dep3/).

Done.

> 
> No, I imagined that you would remove the field entirely. It serves no
> purpose at all.

Ok, field deleted.


>> 
>> I have to take this habit... :) Done.
> 
> Note that it's more a personal preference of mine than a hard rule.

Yet i agree with that method as it's more clearly readable. moreover 
there is no risk to have potential border effects.

> 
> You do what you prefer, I just tell you that you are not forced to do
> this changelog generation.

In this case it's not that userfull as the commit messages are not 
really useful (no "Closing Issue #... or explicit and precise feature 
add).
I will see in the future if there is a real interest to get an upstream 
changelog.

> 
> Of course, even here you can keep your changelog generation if you 
> believe
> it's important.
> 

In that case (when an upstream release exists) i prefer. It can give 
hints for debugging purpose if the upstream purpose if properly written. 
In the case of this software, there is no real interesting content in 
it.

> I let you do the two or three small changes left and then I'll upload 
> the
> package.

Done :)

Cheers,
-- 
Philippe.