[pkg][dhcpig] ready for review

[Raphael Hertzog]

On Fri, 23 Jun 2017, phil at reseau-libre.net wrote:
> > Then please indicate it in the patch headers, I want to see:
> > Bug: https://github.com/.../issue/XXX
> > or something like that (cf DEP-3 http://dep.debian.net/deps/dep3/).
> 
> Done.

Note that it would be fine to put the URL of the pull request only, you
are not forced to open an issue.

You could use the "Forwarded: https://github.com/kamorin/DHCPig/pull/10"
field for example.

> > I let you do the two or three small changes left and then I'll upload
> > the package.
> 
> Done :)

Uploaded but I made some small changes. I dropped "Depends: @" in
debian/tests/control (it's the default value).

I added a small override in debian/rules to make "debian/rules clean" work
even when patches are not applied (as is the case in the git repository)
because in my workflow, sbuild will run this command in my git checkout
to build the source package that will really get built afterwards.

For debian/tests/test-help.sh, I find the test a bit "brittle",
it will fail as soon as the help output gains a line or drops one.
I would have simply grepped the output to make sure that we find some
pre-determined line.

And I would run it without as a standalone command (not a sub-shell in a
pipe) just to make sure that its return value is zero.

Here's what I committed:

#!/bin/sh
set -e

# Ensure --help works
dhcpig --help >$AUTOPKGTEST_TMP/output

# Ensure --help prints something useful
if ! grep -q "http://github.com/kamorin/DHCPig" $AUTOPKGTEST_TMP/output;
then
    echo "ERROR: dhcpig --help looks wrong (no URL output):"
    cat $AUTOPKGTEST_TMP/output
    exit 1
fi

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/