DD request: review chkrootkit
Lukas Schwaighofer
lukas at schwaighofer.name
Mon Jul 24 16:12:33 UTC 2017
Hi Marcos,
I also had a look and found a few other things you might want to
address:
* your override_dh_auto_build is useless
- it has no effect on the binaries, because dh_auto_build calls `make`
and the second `make CFLAGS=[...]` just does nothing as the
binaries are built already (with a more recent timestamp)
- It's not needed as the preprocessor variables are corrected in
./debian/patches/11_logpath.patch and `-DHAVE_LASTLOG_H` is added
to CFLAGS in the Makefile anyways
- there is even a variable name mismatch (WTEMP_FILENAME vs
WTMP_FILENAME)
so I'd suggest you remove it
* instead of having override_dh_installman you could create a
debian/package.manpages file
* Makefile has a few issues
- the "all" target calls `@exec make sense` instead of just depending
on the "sense" target (disrupts parallel build, duplicates any
options added with += in the makefile)
- 20_Proper-flags.patch: you can drop the `CPPFLAGS += -g` line
(`-g` is not a preprocessor flag and added to CFLAGS by
`dpkg-buildflags` automatically)
- I think the Makefile, as is, will not allow cross compiling;
changing `CC = cc` to `CC ?= cc` should be sufficient to address
that
* You can drop `usr/sbin` and `usr/lib/chkrootkit` from debian/dirs
* patch header of 13_exitcode.patch is wrong
Regards
Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170724/c41218ba/attachment.sig>
More information about the Pkg-security-team
mailing list