DD request: review chkrootkit

[Marcos Fouces]

Hello Lukas

I followed all your suggestions but one:

* If i drop -g flag, the resulting dbgsym package does not contain debug 
symbols (and Lintian complaints about it...). I am confused about the 
fact that it is not a preprocessor flag but seems to do its work.

You can check the error i obtain here:

https://lintian.debian.org/tags/debug-file-with-no-debug-symbols.html

Greetings,

Marcos



El 24/07/17 a las 18:12, Lukas Schwaighofer escribió:
> Hi Marcos,
>
> I also had a look and found a few other things you might want to
> address:
>
> * your override_dh_auto_build is useless
>    - it has no effect on the binaries, because dh_auto_build calls `make`
>      and the second `make CFLAGS=[...]` just does nothing as the
>      binaries are built already (with a more recent timestamp)
>    - It's not needed as the preprocessor variables are corrected in
>      ./debian/patches/11_logpath.patch and `-DHAVE_LASTLOG_H` is added
>      to CFLAGS in the Makefile anyways
>    - there is even a variable name mismatch (WTEMP_FILENAME vs
>      WTMP_FILENAME)
>    so I'd suggest you remove it
>
> * instead of having override_dh_installman you could create a
>    debian/package.manpages file
>
> * Makefile has a few issues
>    - the "all" target calls `@exec make sense` instead of just depending
>      on the "sense" target (disrupts parallel build, duplicates any
>      options added with += in the makefile)
>    - 20_Proper-flags.patch: you can drop the `CPPFLAGS += -g` line
>      (`-g` is not a preprocessor flag and added to CFLAGS by
>      `dpkg-buildflags` automatically)
>    - I think the Makefile, as is, will not allow cross compiling;
>      changing `CC = cc` to `CC ?= cc` should be sufficient to address
>      that
>
> * You can drop `usr/sbin` and `usr/lib/chkrootkit` from debian/dirs
>
> * patch header of 13_exitcode.patch is wrong
>
> Regards
> Lukas