[pkg] brutespray - review

[Stéphane Neveu]

Sorry, priority updated to optional

2017-07-25 15:36 GMT+02:00 Stéphane Neveu <stefneveu at gmail.com>:
> Hi all,
>
> 2017-07-24 11:24 GMT+02:00 Raphael Hertzog <hertzog at debian.org>:
>> On Thu, 20 Jul 2017, Lukas Schwaighofer wrote:
>>> * Is there a reason this package has the debian/source/options file? (I
>>>   still don't know what these options are used for and I remember you
>>>   dropped them in curvedns after I asked…)
>>
>> FYI debian/source/options are options for dpkg-source.
>>
>> On Fri, 21 Jul 2017, Lukas Schwaighofer wrote:
>>> * debian/control: Priority standard is too high (that's basically a
>>>   statement, that you expect this package to be installed on a "normal"
>>>   installation). It should probably be either optional or extra (I do
>>>   lean towards extra).  Check the Debian Policy [1] for an explanation.
>>
>> Please use optional. "extra" is going to disappear soon (check bugs
>> against debian-policy if you want to find out the proposal)
>> and is generally mis-used.
>
> * Priority updated to extra (Thanks Raphaël)
> * Upstream script has been updated to use mkdtemp() (tag is now
> brutespray-1.5.2)
> * -o option has also been added to provide a custom output directory
> (install.patch is pointing on /usr/share/brutespray for that dir)
> * brutespray.1.ronn and changelog updated
> * debian/master, upstream/latest and pristine-tar branch pushed on alioth.
>
> I hope I haven't forgotten something
>
> Best regards,
>
> Stephane