[pkg] brutespray - review

Tue Jul 25 14:00:35 UTC 2017

Hi,

On Tue, 25 Jul 2017 15:36:21 +0200
Stéphane Neveu <stefneveu at gmail.com> wrote:
> * -o option has also been added to provide a custom output directory
> (install.patch is pointing on /usr/share/brutespray for that dir)

That's not a good default, because normal users won't have write
permissions there…  keeping brutespray-output (relative to the cwd)
seems like a reasonable default to me.

Otherwise I think you've addressed everything I had raised.  Great that
you were able to introduce proper temporary file handling upstream!

Regards
Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170725/b21823b7/attachment.sig>