Bug#319136: [Pkg-shadow-devel] Bug#319136: passwd: config script silently fails if invalid group file is present

Marc Haber mh+debian-bugs at zugschlus.de
Fri Jul 22 05:48:08 UTC 2005


On Fri, Jul 22, 2005 at 12:08:00AM +0300, Alexander Gattin wrote:
> On Wed, Jul 20, 2005 at 08:00:09AM +0200, Marc Haber wrote:
> > the config script fails with exit code 1 (but without error message)
> > if shadowconfig fails, for example when a syntax error is found in the
> > group file.
> 
> But, err..., when there's a syntax error in
> /etc/group or /etc/passwd file, the whole system can be
> considered broken, at least partially. Couldn't it?

So have the program say so and then error out. Silently failing is not
an option.

> > A little more error checking would be good.
> 
> Marc, sorry, could you please explain in more details
> what you mean here?

if ! shadowconfig bla; then
  echo >&2 "ERR: shadowconfig failed"
  exit 1
fi

Having the -e trip is something to be avoided.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835




More information about the Pkg-shadow-devel mailing list