[Pkg-shadow-devel] Re: [Pkg-shadow-commits] r814 - trunk/debian/patches

[Christian Perrier]

Quoting Alexander Gattin (xrgtn-guest at costa.debian.org):
> Author: xrgtn-guest
> Date: 2006-01-16 21:11:01 +0000 (Mon, 16 Jan 2006)
> New Revision: 814
> 
> Modified:
>    trunk/debian/patches/486_nowarn
> Log:
> added comments to the patch


I have a comment about this, not technical but rather organizational.

I would really like to avoid piling up Debian patches which are
upstream patches unless they fixe issues tagged as "important" in our
BTS.

As Debian maintainers, our duty is to make our patches flow to
upstream so all these should really go to upstream *before* going to
our package.

Tomasz does not read the -commits list and we can't expect him to do
so.

So I would really see some discussion with Tomasz either before
commiting these patches or immediately after. Actually this mail is a
way for hom to notice this..:-)

Alexander, this was maybe your intent, so please forgive me if I'm
overzealous here, but I really suggest you forward the 486 patch to
Tomasz ASAP.....

For further changes/suggestions, I think that prior discussion
involving Tomasz, in the mailing list or on IRC would be good.

Again, not "rejecting" your work in any way, just something I wanted
to enhance. In short, I still want our diff.gz file to get smaller and
smaller, not bigger and bigger.


It is currently 169k...let's say that 100k is the goal for
4.0.15-1...:-)