[Pkg-shadow-devel] Re: [Pkg-shadow-commits] r814 - trunk/debian/patches

[Alexander Gattin]

Hi!

On Tue, Jan 17, 2006 at 07:39:06AM +0100, Christian Perrier wrote:
> I would really like to avoid piling up Debian patches which are
> upstream patches unless they fixe issues tagged as "important" in our
> BTS.
or at least fixing any bug, agreed. I share the same
view. I didn't like adding a patch without
Fixes:/Closes: statement, BTW.

> So I would really see some discussion with Tomasz either before
> commiting these patches or immediately after.

Yes, I asked Tomasz to review patches 484-486, and from
my side promised him to modify the patches in order for
them to be directly applicable to his CVS.

> For further changes/suggestions, I think that prior discussion
> involving Tomasz, in the mailing list or on IRC would be good.

This time I just wanted to _expose_ the patches
somewhere outside the working directory of my home
computer and also I wanted some help from you, Nicolas,
Christine or somebody else with setting CFLAGS in cdbs.

Taking 486th patch, the intent is to allow building
with "-Wall -Werror". This is considered good common
practice (like e.g. "use strict;" in perl), because it
helps to find some class of errors during compilation,
otherwise unreported.

I thought we could modify our debian/rules makefile to
build shadow with "-Wall -Werror" and this patch is
required for such build to succeed.

But, I got a lot of problems when added "-Wall -Werror"
to debian/rules myself (as best as I could). Finally
I traced source of problems (or at least I'm quite
confident that I do not mistake) to ./configure script
being run with CFLAGS containing "-Wall -Werror".

Technically, AFAIR, ./configure compiles lot of little
code snippets to detect appropriate header files etc.
With "-Wall -Werror" some snippets, e.g. "snprintf", fail
to compile, I think, not due to lack of snprintf
definition in standard header files, but just because
of more strict checking ("-Wall -Werror").

So, my question is:
how can I append "-Wall -Werror" to CFLAGS using our
debian/rules and cdbs during _make_ phase only, and do
not have "-Wall -Werror" during ./configure?

P.S. Of course I don't want to keep this Debian-only.

-- 
WBR,
xrgtn