[Pkg-shadow-devel] groupmems produces segmentation fault

[Nicolas François]

Hi Peter,

On Mon, Feb 18, 2008 at 05:19:06PM +0100, pvrabec at redhat.com wrote:
> 
> groupmems -a customer -g test 
> Segmentation fault
> 
> when /etc/group looks like:
> ...
> test:x:10007:
> ...
> 
> I think groupmems.c:109 in addtogroup()
> - members = (char **) realloc (members, sizeof (char *) * i);
> +members = (char **) realloc (members, sizeof (char *) * (i+1));
> 
> Is it OK?

Thanks for reporting it.

I even think it should be (i+2) since members[i + 1] will be set to NULL.

It's committed.

Note: I've no testsuite currently for groupmems because it is not
installed on Debian. I will try to fix this later.

Best Regards,
-- 
Nekral