[Pkg-shadow-devel] groupmems produces segmentation fault

[Peter Vrabec]

On Monday 18 February 2008 10:56:30 pm Nicolas François wrote:

> > I think groupmems.c:109 in addtogroup()
> > - members = (char **) realloc (members, sizeof (char *) * i);
> > +members = (char **) realloc (members, sizeof (char *) * (i+1));
> >
> > Is it OK?
>
> Thanks for reporting it.
>
> I even think it should be (i+2) since members[i + 1] will be set to NULL.
yeah, I'm sorry, you are right.