[Pkg-shadow-devel] groupmems: invalid usernames handling && segfault fix

Nicolas François nicolas.francois at centraliens.net
Mon Jul 21 23:29:31 UTC 2008

Hello Lukáš,

On Mon, Jul 21, 2008 at 04:30:52PM +0200, lkukline at redhat.com wrote:
> Greetings,
> I have some (eh, two) bugfixes for groupmems utility.
> Relevant bugzilla entries:
> https://bugzilla.redhat.com/show_bug.cgi?id=455603
> https://bugzilla.redhat.com/show_bug.cgi?id=456088
> Attached patch applies against shadow-4.1.2

Thanks for the patch. I will probably make a few changes and check the
parameters earlier. Also, I would like to harmonize the error messages
from groupmems with the other tools.

For 455603, instead of checking if the username is valid, shouldn't we
check if the user exists?

Best Regards,

More information about the Pkg-shadow-devel mailing list