[Pkg-shadow-devel] groupmems: invalid usernames handling && segfault fix

Lukas Kuklinek lkukline at redhat.com
Tue Jul 22 09:12:51 UTC 2008

Dne Tuesday 22 of July 2008 01:29:31 Nicolas François napsal(a):
> Hello Lukáš,
> Thanks for the patch. I will probably make a few changes and check the
> parameters earlier. Also, I would like to harmonize the error messages
> from groupmems with the other tools.

All right, at least you know about the problem ;)

> For 455603, instead of checking if the username is valid, shouldn't we
> check if the user exists?

Good point, I was kinda "driven" by the bugzilla entry and didn't think about 
it much... :]. But it should be fixed just by replacing check_user_name() by 
getpwnam(), right?

Thanks for reply.


More information about the Pkg-shadow-devel mailing list