Bug#602328: libapache2-mod-shib2: apache should be restarted on install/upgrade

[Ferenc Wagner]

Russ Allbery <rra at debian.org> writes:

> Ferenc Wagner <wferi at niif.hu> writes:
>
>> We started discussing this in January, but the thread died off without
>> reaching conclusion:
>> http://lists.alioth.debian.org/pipermail/pkg-shibboleth-devel/2010-January/001565.html
>> I doubt we can do anything about this so close to release, but if at all
>> possible, we should.
>
> I agree that we should restart it.  I think the open question was what
> level of restart we needed to do, and it sounded like reload wasn't
> enough.

Yes.

> Looks like doing restart would be enough. 

Maybe I'm missing something, what more could we do beyond a restart?

> We should probably guard that restart by first checking whether the
> Shibboleth Apache module is enabled; if the user never enabled it,
> upgrading it shouldn't restart Apache.

I can't find a specific tool in the a2(en/dis)mod family for checking
the status of a module.  I hope it's correct to directly check for the
/etc/apache2/mods-enabled/shib2.load symlink.

As Faidon Liambotis, whom we welcome on board, has already committed
changes into the debian branch which probably aren't suitable for
squeeze (memcache support), I guess we should split off a squeeze branch
at be3e3bf8 or 2a353330.  Which one do you prefer?  The difference is
Faidon's presence amongst the uploaders.
-- 
Cheers,
Feri.