opensaml2, pkg-config on wheezy and PKG_CHECK_VAR macro

[Etienne Dysli-Metref]

On 18/10/16 10:18, Ferenc Wágner wrote:
> I forgot to output it like
> 
> AC_SUBST([DX_INCLUDE], [`pkg-config xmltooling --variable=includedir`])

That one works too. :)

> On the other hand, maybe it would be easier to just ship a newer pkg.m4
> in the m4 directory, and do away with the patch eliminating
> PKG_INSTALLDIR as well.  Especially for the SP, which uses PKG_CHECK_VAR
> several times.

Would we be allowed to ship a copy of jessie's
/usr/share/aclocal/pkg.m4? That seems the easiest and fastest solution
and would save a bunch a patching/reverting.

> Or request a backport of pkg-config..:)

That's probably a good long term solution. Where/to who should we
request a backport?

Hmm I still get some unit test failures after deleting the networked
tests... :/ Did you hit those?

make  check-TESTS
make[4]: Entering directory `/build/opensaml2-2.6.0/samltest'
Running 311 tests........
1476808039 ERROR XMLTooling.ParserPool : fatal error on line 1, column
1, message: invalid document structure
In EncryptedAssertionTest::testEncryptedAssertion:
encryption/EncryptedAssertionTest.h:66: Error: Test failed: XML error(s)
during parsing, check log for specifics
encryption/EncryptedAssertionTest.h:66: Error: Test failed: Exception
thrown from setUp()
encryption/EncryptedAssertionTest.h:66: Error: Expected
(suite()->setUp(); ok=true) not to throw, but it did
1476808039 ERROR XMLTooling.ParserPool : fatal error on line 1, column
1, message: invalid document structure
In SAML1AssertionTest::testSignature:
signature/SAML1AssertionTest.h:39: Error: Test failed: XML error(s)
during parsing, check log for specifics
signature/SAML1AssertionTest.h:39: Error: Test failed: Exception thrown
from setUp()
signature/SAML1AssertionTest.h:39: Error: Expected (suite()->setUp();
ok=true) not to throw, but it did
1476808039 ERROR XMLTooling.ParserPool : fatal error on line 1, column
1, message: invalid document structure
In SAML1RequestTest::testSignature:
signature/SAML1RequestTest.h:42: Error: Test failed: XML error(s) during
parsing, check log for specifics
signature/SAML1RequestTest.h:42: Error: Test failed: Exception thrown
from setUp()
signature/SAML1RequestTest.h:42: Error: Expected (suite()->setUp();
ok=true) not to throw, but it did
1476808039 ERROR XMLTooling.ParserPool : fatal error on line 1, column
1, message: invalid document structure
In SAML1ResponseTest::testSignature:
signature/SAML1ResponseTest.h:42: Error: Test failed: XML error(s)
during parsing, check log for specifics
signature/SAML1ResponseTest.h:42: Error: Test failed: Exception thrown
from setUp()
signature/SAML1ResponseTest.h:42: Error: Expected (suite()->setUp();
ok=true) not to throw, but it did
1476808039 ERROR XMLTooling.ParserPool : fatal error on line 1, column
1, message: invalid document structure
In SAML2AssertionTest::testSignature:
signature/SAML2AssertionTest.h:39: Error: Test failed: XML error(s)
during parsing, check log for specifics
signature/SAML2AssertionTest.h:39: Error: Test failed: Exception thrown
from setUp()
signature/SAML2AssertionTest.h:39: Error: Expected (suite()->setUp();
ok=true) not to throw, but it did
1476808039 ERROR XMLTooling.ParserPool : fatal error on line 1, column
1, message: invalid document structure
In ExplicitKeyTrustEngineTest::testExplicitKeyTrustEngine:
security/ExplicitKeyTrustEngineTest.h:43: Error: Test failed: XML
error(s) during parsing, check log for specifics
/usr/include/cxxtest/TestRunner.h:35: Error: Test failed: Exception
thrown from world
FAIL: samltest
===============================================
1 of 1 test failed
Please report to https://issues.shibboleth.net/
===============================================
make[4]: *** [check-TESTS] Error 1
make[4]: Leaving directory `/build/opensaml2-2.6.0/samltest'
make[3]: *** [check-am] Error 2
make[3]: Leaving directory `/build/opensaml2-2.6.0/samltest'
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory `/build/opensaml2-2.6.0'
dh_auto_test: make -j4 check SAMLTEST_SKIP_NETWORKED=1 returned exit code 2

  Etienne

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-shibboleth-devel/attachments/20161018/3475b35c/attachment.sig>