opensaml2, pkg-config on wheezy and PKG_CHECK_VAR macro

[Ferenc Wágner]

Etienne Dysli-Metref <etienne.dysli-metref at switch.ch> writes:

> On 18/10/16 10:18, Ferenc Wágner wrote:
>
>> On the other hand, maybe it would be easier to just ship a newer pkg.m4
>> in the m4 directory, and do away with the patch eliminating
>> PKG_INSTALLDIR as well.  Especially for the SP, which uses PKG_CHECK_VAR
>> several times.
>
> Would we be allowed to ship a copy of jessie's
> /usr/share/aclocal/pkg.m4?

Debian already distributes that file, it's license is GPL-2+ with the
usual Autoconf exception, so we're allowed to ship it.

> That seems the easiest and fastest solution and would save a bunch a
> patching/reverting.

Yes, provided it actually works.  Its serial seems neglected, and I'm
unsure about its compatibility with older pkg-config binaries.  Also,
just copying it into m4/ may not work, because the system copy in
/usr/share/aclocal takes precedence.  So it may be safer to just copy
the missing macro definitions (PKG_INSTALLDIR and PKG_CHECK_VAR) into
m4/pkg-new.m4 or similar.

>> Or request a backport of pkg-config..:)
>
> That's probably a good long term solution. Where/to who should we
> request a backport?

We could ask its maintainer (Tollef Fog Heen) for one.  But let's try to
find an upstreamable option first.

> Hmm I still get some unit test failures after deleting the networked
> tests... :/ Did you hit those?
> [...]

No, but they look like data/binding/ExampleMetadataProvider.xml or
example-metadata.xml is not found or empty.  Maybe they are being looked
for on the wrong path.  You might try strace -eopen to find out.
-- 
Feri