[Pkg-sssd-devel] [tag2upload 3044] irrecoverable sssd 2.12.0-3~exp0 [and 1 more messages]

[Ian Jackson]

(dropping the debian-tag2upload list, which is not for discussion)

Debian tag2upload service writes ("[tag2upload 3044] irrecoverable sssd 2.12.0-3~exp0"):
> multiple possibilities for orig component orig:
>   main: 5cef12b47fcb76f250bd9e00e5e5fea2df3b1ffc6d3d7e9ba1dbe753acac8880 s/sssd/sssd_2.12.0.orig.tar.gz
>   main: 7fb4458ad68e2e7f8d198a972abe8331a56af585d62a29875132fb169ec3ed84 s/sssd/sssd_2.12.0.orig.tar.gz.asc
> failed to resolve, unambiguously, which .origs are intended

These messages are wrong.  I have filed #1130113.

But it isn't fatal.  The tag2upload service ran git-deborig:

> # conflicting orig(s) in archive, regenerating, hoping to reproduce a good one
> + git deborig 1a1cf163b78ff4768cc8bfc1e631171bc021e2fe
> # created orig

It reproduced the sssd_2.12.0.orig.tar.gz (with the same hash, I
believe).  It then proceeded to do the rest of the upload processing
using that regenerated copy of sssd_2.12.0.orig.tar.gz, and
disregarding the .asc (which is not ideal, but tolerable).

However, then, the processing failed, with this message.

> dgit (build host): error: git tree contains debian/source/local-options

As Sean said, this is always a fatal error.  It has nothing to do with
origs.  The issue with origs is completely orthogonal.


Simon Josefsson writes ("Re: [tag2upload 3044] irrecoverable sssd 2.12.0-3~exp0"):
> 3) Git repository has debian/source/local-options cuasing tag2upload to
> not synthesize a new *.orig.tar.

No.  debian/source/local-options has no effect on tag2upload's efforts
to obtain suitable orig(s).

A correct statement would be

  Git repository has debian/source/local-options cuasing tag2upload
  unconditioally fail the upload.  The upload failed despite
  tag2upload having successfully obtained a useable orig even though
  this upload was afllicted by an unconnected bug in orig processing
  which caused some confusing messages about origs.

> 4) Use of --force=local-options to ignore 3) and proceed with the
> tag2upload.

This was doomed.  --force=local-options will never work with the
Debian tag2upload service.  (In theory it might work with a different
target system with different, much looser, principles of operation.)

> Why can't tag2upload use the orig tarball from the archive when there is
> a d/source/local-options file?

In direct answer to your question:

Because tag2upload *cannot function at all in any way and the upload
will always fail when there is a d/source/local-options file*.

Regardless of any origs.  Native packages with a
d/source/local-options file will also fail.

> For sssd d/source/local-options contains extend-diff-ignore, and I don't
> see how re-use of the *.orig.tar.* in the archive would be bad.

It doesn't mattter what is in d/source/local-options.  No tag2upload
or dgit upload of a git tree containing ddebian/source/local-options
can ever succeed.

The reason is that dpkg-source doesn't include
debian/source/local-options when it builds the source package.

If this specific error check were removed, what would happen is;
 - dgit would get dpkg-source to build a source package
 - dpkg-source would omit d/source/local-options from the output
 - dgit would unpack the source package as part of its usual check
   that its invariants are being preserved
 - dgit would discover that thte source package unpacks to a tree
   without d/source/local-options, and notice that this is not
   identical to the input git tree.
 - the upload would then be aborted.

So d/source/local-options must be removed, or its contents transferred
to debian/source/options (if appropriate).

The extend-diff-ignore option is not very useful in git-based
workflows.  Its function is to cause things that are in your working
tree (ie, in git) not to appear in the source package.  That's a
violation of the principle that the source package must be identical
to git.

I think an extend-diff-ignore can exist in d/source/options (not
local-options) and not prevent a git-based upload, but *only* if none
of the files it mentions are in git.  In which case it's not needed.

> It may that this error had nothing to do with d/source/local-options,
> though.

No, the failure is *only* to do with d/source/local-options.

Ian.

-- 
Ian Jackson <ijackson at chiark.greenend.org.uk>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.