[Pkg-sugar-devel] Patch for Browse package

Jonas Smedegaard jonas at jones.dk
Wed Apr 26 19:11:52 UTC 2017

Quoting Sebastian Silva (2017-04-26 17:10:13)
> I've been trying to follow your advice. Although I moved forward, I 
> still have some questions.
> I've managed to produce a patch with /quilt/ for the 2001 patch. The 
> issue seems to be that quilt ignores empty files.

I believe that's a more general challenge: Git tracks _content_ so might 
also be unhappy with empty files (possibly in some corner cases, even if 
it works generally).

> The attached patch just adds __init__.py with a comment. But I left 
> the changelog or bumping versions, not sure if they should be 
> included.

Well, you can look at the git history for inspiration ;-)

I prefer to commit each semantic change separately, with a commit 
message likely usable directly as a changelog line. Then generate a 
draft changelog update with "gbp dch -a", adjust it, and commit together 
with automated changes (updates to copyright_hints and to package 
relations in control file).

As for comments in the header of the patch, please use DEP3 syntax: 

> My difficulty comes when trying to build the package. I have tried 
> both `gbp buildpackage` (promising, no result, complains about not 
> pushed commits, and after pushing to a clone, about untracked files, 
> and finally about not having Jonas's secret key) and also tried `sudo 
> debian/rules binary` which produces a package without patches.

Try if this succeeds:

  gbp buildpackage --git-ignore-new --git-no-sign-tags

> Upstream also has a fix for #861052 which actually turns out to be a 
> bug in Browse too, James, do you think we should add this patch to 
> Stretch?

Please discuss bugs at their bugreport, rather than here on the list: 
That helps the release team quickly understand a bug, needed for them to 
judge if they consider it reasonable for an sxception the to freeze.

 - Jonas

 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-sugar-devel/attachments/20170426/f6d4a09a/attachment.sig>

More information about the pkg-sugar-devel mailing list