[Pkg-systemd-maintainers] systemd support for amavisd-new

[Michael Stapelberg]

Hi Christian,

Christian Dröge <person at christian-droege.de> writes:
> I want to help to improve the systemd support in Debian by adding
> service files to packages and the first package, that I want to work on,
> is amavisd-new. It was recommended to get in touch with this list for
> this.
Thanks for getting in touch.

> diff -Nru amavisd-new-2.8.0/debian/amavisd-new.amavis.service amavisd-new-2.8.0/debian/amavisd-new.amavis.service
> --- amavisd-new-2.8.0/debian/amavisd-new.amavis.service	1970-01-01 01:00:00.000000000 +0100
> +++ amavisd-new-2.8.0/debian/amavisd-new.amavis.service	2014-02-07 22:22:02.000000000 +0100
> @@ -0,0 +1,11 @@
> +[Unit]
> +Description=Interface between MTA and virus scanner/content filters
> +After=network.target
> +
> +[Service]
> +PIDFile=/var/run/amavis/amavisd-new.pid
Note that you can use /run instead of /var/run (the latter is just a
symlink to the former).

> +ExecStart=/usr/sbin/amavisd-new foreground
> +ExecReload=/usr/sbin/amavisd-new reload
> +
> +[Install]
> +WantedBy=multi-user.target
> diff -Nru amavisd-new-2.8.0/debian/amavisd-new.amavis.tmpfile amavisd-new-2.8.0/debian/amavisd-new.amavis.tmpfile
> --- amavisd-new-2.8.0/debian/amavisd-new.amavis.tmpfile	1970-01-01 01:00:00.000000000 +0100
> +++ amavisd-new-2.8.0/debian/amavisd-new.amavis.tmpfile	2014-02-07 17:00:53.000000000 +0100
> @@ -0,0 +1,3 @@
> +d	/var/run/amavis			0750	amavis amavis
> +R	/var/lib/amavis/amavis-*
> +R	/var/lib/amavis/tmp/amavis-*
I think this is the first case of r/R being used at all in a tmpfile
snippet. Do these files really only need to be removed once when booting?

Apart from those two remarks, the patch looks good to me.

-- 
Best regards,
Michael