[Pkg-systemd-maintainers] systemd support for amavisd-new

[Christian Dröge]

Hi Michael,

Am 08.02.2014 00:04, schrieb Michael Stapelberg:
>> diff -Nru amavisd-new-2.8.0/debian/amavisd-new.amavis.service amavisd-new-2.8.0/debian/amavisd-new.amavis.service
>> --- amavisd-new-2.8.0/debian/amavisd-new.amavis.service	1970-01-01 01:00:00.000000000 +0100
>> +++ amavisd-new-2.8.0/debian/amavisd-new.amavis.service	2014-02-07 22:22:02.000000000 +0100
>> @@ -0,0 +1,11 @@
>> +[Unit]
>> +Description=Interface between MTA and virus scanner/content filters
>> +After=network.target
>> +
>> +[Service]
>> +PIDFile=/var/run/amavis/amavisd-new.pid
> Note that you can use /run instead of /var/run (the latter is just a
> symlink to the former).

This is corrected in a new patch, that is attached to this mail. I was
unsure, if I should use the exact path as the init script.

>> +ExecStart=/usr/sbin/amavisd-new foreground
>> +ExecReload=/usr/sbin/amavisd-new reload
>> +
>> +[Install]
>> +WantedBy=multi-user.target
>> diff -Nru amavisd-new-2.8.0/debian/amavisd-new.amavis.tmpfile amavisd-new-2.8.0/debian/amavisd-new.amavis.tmpfile
>> --- amavisd-new-2.8.0/debian/amavisd-new.amavis.tmpfile	1970-01-01 01:00:00.000000000 +0100
>> +++ amavisd-new-2.8.0/debian/amavisd-new.amavis.tmpfile	2014-02-07 17:00:53.000000000 +0100
>> @@ -0,0 +1,3 @@
>> +d	/var/run/amavis			0750	amavis amavis
>> +R	/var/lib/amavis/amavis-*
>> +R	/var/lib/amavis/tmp/amavis-*
> I think this is the first case of r/R being used at all in a tmpfile
> snippet. Do these files really only need to be removed once when booting?

I misunderstood, when systemd cleans up those files. They need to be
cleaned up after the daemon has stopped, so I changed this in the
service file. Hopefully this is implemented correctly by me.

> Apart from those two remarks, the patch looks good to me.

Great. Thank you.

Best regards
Christian Dröge
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amavisd_systemd_support.patch
Type: text/x-patch
Size: 2296 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20140208/751d5729/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20140208/751d5729/attachment-0002.sig>