csync2 socket and service file

[Felipe Sateler]

Hi Dhionel,

On 6 December 2015 at 21:14, Dhionel Díaz <ddiaz at cenditel.gob.ve> wrote:
> Hi everyone,
>
> Following the directions in https://wiki.debian.org/systemd/HowToHelp
> I've attached files that can be used to make csync2 a socket activated
> service and avoid the use of inetd, they are based on the ones published
> in
> https://github.com/mk-fg/fg_exheres/tree/master/packages/sys-apps/csync2/files/systemd.
> The configuration has been tested in a four node cluster.

Excellent! Let's see this:

>
> I'll be awaiting your review.


csync2.socket

> [Socket]
> ListenStream = 30865

Please don't use spaces around the '=' sign. This currently works, but
is not part of the spec and may stop working in the future. Moreover,
some debian tools do not handle this well. This applies to both files.

> Accept = true
>
> [Install]
> WantedBy = sockets.target

This should also have a description in a [Unit] section. Other than
that, looks good.

csync2 at .service

> [Unit]
> Description = csyn2 asynchronous file synchronization
>
> [Service]
> User = csync2
> Group = csync2

The current package does not appear to create its own csync2 user, and
runs it as root under inetd. I don't know which is appropriate.

> ExecStart = -/usr/sbin/csync2 -i
> StandardInput = socket
> StandardOutput = socket

The StandardOutput line should not be needed, as it is inherited from
StandardInput.


-- 

Saludos,
Felipe Sateler