Bug#761909: systemd does not unmount nfs shares before bringing down the network interface

[Martin Pitt]

Control: tag -1 pending

Hello Michael,

Michael Biebl [2015-10-05 12:11 +0200]:
> Originally I designed it that way: no Conflicts=shutdown.target and
> letting networking.service do the clean up on shutdown.
> 
> ifup at .service was changed in the mean time. I wonder if the
> PartOf=network.target breaks that.

That's indeed it! I dropped it, and ifup@*.service isn't stopped on
shutdown any more.

The PartOf= has a rather long history: It got introduced in 1afebb7,
immediately reverted in fc63e489, and reintroduced in 3d857c21.

However, with dropping the PartOf=, I just verified that "systemctl
isolate emergency.target" still works fine -- as
/etc/init.d/networking is stopped anyway, all interfaces get stopped,
so we don't need to do that again via ifup at .service.
I dont know why this didn't work back then, or it was just an
oversight. But I dropped the PartOf= again in git now.

Michael Biebl [2015-10-05 12:28 +0200]:
> We bind the unit to the lifetime of the interface, i.e. we want to run
> ifdown $iface if the device is unplugged. So I don't think we should
> remove the ExecStop, at least not without making sure that this would
> cause regressions, like stale ifupdown state files.

Indeed. I think it's fine as it is now, you can stop it manually but
it doesn't stop automatically on shutdown any more.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20151005/6209caa8/attachment-0002.sig>