Bug#812357: cgroupfs-mount: Mask initscript by creating a symlink to /dev/null instead of bailing at the begining of the script

Laurent Bigonville bigon at debian.org
Fri Jan 22 16:25:48 GMT 2016


Package: cgroupfs-mount
Version: 1.2
Severity: normal

Hi,

The initscript contains the following code:

# Test for systemd and bail (we have to test before sourcing init-functions, or systemd hijacks us)
# We bail because systemd already mounts cgroups sanely, so we just silently pretend we were successful in mounting them here
if [ -d /run/systemd/system ]; then
        exit 0
fi

Shouldn't it better to create a symlink to mask the initscript by creating a
symlink to /dev/null so this script is not even considered?

ln -s /dev/null /lib/systemd/cgroupfs-mount

I guess we need to be sure no other LSB iniscript has a dependency against
cgroupfs-mount one. I see only one rdep (docker.io) and it has a native
.service file so it's OK.

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.4.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

cgroupfs-mount depends on no packages.

cgroupfs-mount recommends no packages.

Versions of packages cgroupfs-mount suggests:
pn  mountall  <none>

-- no debconf information



More information about the Pkg-systemd-maintainers mailing list