Bug#830208: dh_systemd_enable and dh_installinit both install unit files

[Felix Dreissig]

Package: dh-systemd
Version: 1.36
Severity: normal

Dear dh-systemd developers,

at the moment, systemd unit files get installed by both dh_installinit and
dh_systemd_enable. There is a comment in dh_systemd_enable regarding this:

> XXX: This is duplicated in dh_installinit, which is unfortunate.  We do need
> the service files before running dh_installinit though, every other solution
> makes things much worse for all the maintainers.

However, I could not find a corresponding bug report, so I decided to open
this one. If you see no way to improve the situation, feel free to close it.

I just encountered a case where this behavior led to practical problems:

In the particular package, dh_installinit is called using `-d`, so that the
'd' suffix gets stripped from the unit file name. dh-systemd does not do that
(and also has no such option), so it installs the same file with the 'd'
suffix and both unit files end up in /lib/systemd/system.

In this case, I was able to fix the issue by switching to `--name`, which is
supported by dh_systemd_enable as well.
But the underlying issue that both programs install the same files with
potentially different configurations remains.

Best regards,
Felix