Bug#825858: systemd-insserv-generator shouldn't create insserv dependencies if the unit is masked

[Laurent Bigonville]

Package: systemd
Version: 230-1
Severity: normal

Hi,

rpcbind is now providing a .service file, but the
systemd-insserv-generator is still creating dependency information base
on it:

# /run/systemd/generator/rpcbind.service.d/50-rpcbind-$portmap.conf
# Automatically generated by systemd-insserv-generator

[Unit]
Wants=rpcbind.target
Before=rpcbind.target

and also

# /run/systemd/generator/rpcbind.target.d/50-hard-dependency-rpcbind-$portmap.conf
# Automatically generated by systemd-insserv-generator

[Unit]
SourcePath=/etc/insserv.conf.d/rpcbind
Requires=rpcbind.service

Shouldn't systemd-insserv-generator ignore inserv informations if the
LSB initscript is masked by a systemd service?

That would also need to check that the .service files have the proper
dependencies.

Cheers,

Laurent Bigonville

-- Package-specific info:

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.5.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages systemd depends on:
ii  adduser         3.114
ii  libacl1         2.2.52-3
ii  libapparmor1    2.10-4
ii  libaudit1       1:2.5.2-1
ii  libblkid1       2.28-5
ii  libc6           2.22-9
ii  libcap2         1:2.25-1
ii  libcap2-bin     1:2.25-1
ii  libcryptsetup4  2:1.7.0-2
ii  libgcrypt20     1.7.0-2
ii  libgpg-error0   1.22-2
ii  libkmod2        22-1.1
ii  liblzma5        5.1.1alpha+20120614-2.1
ii  libmount1       2.28-5
ii  libpam0g        1.1.8-3.2
ii  libseccomp2     2.3.1-2
ii  libselinux1     2.5-3
ii  libsystemd0     230-1
ii  mount           2.28-5
ii  util-linux      2.28-5

Versions of packages systemd recommends:
ii  dbus            1.10.8-1
ii  libpam-systemd  230-1

Versions of packages systemd suggests:
pn  systemd-container  <none>
pn  systemd-ui         <none>

Versions of packages systemd is related to:
ii  udev  230-1

-- no debconf information