Bug#825858: systemd-insserv-generator shouldn't create insserv dependencies if the unit is masked

[Laurent Bigonville]

On Mon, 30 May 2016 22:25:25 +0200 Laurent Bigonville <bigon at debian.org> 
wrote:

 > Hi,
 >
 > rpcbind is now providing a .service file, but the
 > systemd-insserv-generator is still creating dependency information base
 > on it:
 >
 > # /run/systemd/generator/rpcbind.service.d/50-rpcbind-$portmap.conf
 > # Automatically generated by systemd-insserv-generator
 >
 > [Unit]
 > Wants=rpcbind.target
 > Before=rpcbind.target
 >
 > and also
 >
 > # 
/run/systemd/generator/rpcbind.target.d/50-hard-dependency-rpcbind-$portmap.conf
 > # Automatically generated by systemd-insserv-generator
 >
 > [Unit]
 > SourcePath=/etc/insserv.conf.d/rpcbind
 > Requires=rpcbind.service
 >
 > Shouldn't systemd-insserv-generator ignore inserv informations if the
 > LSB initscript is masked by a systemd service?
 >
 > That would also need to check that the .service files have the proper
 > dependencies.

On the other hand, it seems that the generator is not adding a Requires 
in the .service generated for nfs-common:

# /run/systemd/generator.late/nfs-common.service
# Automatically generated by systemd-sysv-generator

[Unit]
Documentation=man:systemd-sysv-generator(8)
SourcePath=/etc/init.d/nfs-common
Description=LSB: NFS support files common to client and server
DefaultDependencies=no
Before=sysinit.target
Before=multi-user.target
Before=multi-user.target
Before=multi-user.target
Before=graphical.target
Before=shutdown.target
After=rpcbind.target
After=time-sync.target
Conflicts=shutdown.target

[Service]
Type=forking
Restart=no
TimeoutSec=0
IgnoreSIGPIPE=no
KillMode=process
GuessMainPID=no
RemainAfterExit=yes
ExecStart=/etc/init.d/nfs-common start
ExecStop=/etc/init.d/nfs-common stop

$ grep portmap /etc/init.d/nfs-common
# Required-Start:    $portmap $time