Bug#909396: Bug#914543: meson adds both -fPIE and -fPIC options in LTO compiles with gcc-8

[John David Anglin]

Hi,

The merging of PIC/PIE options in gcc-8 was fixed by this change:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=267610

A new build of gcc-8 with the above change was upload yesterday and
systemd 240-3 built
successfully on hppa without having to disable LTO:
https://buildd.debian.org/status/fetch.php?pkg=systemd&arch=alpha&ver=240-3&stamp=1547070353&raw=0
 
On 2019-01-10 7:09 a.m., Michael Biebl wrote:
> Hi Dave, hi Jussi
>
> On Sat, 1 Dec 2018 17:15:41 -0500 John David Anglin
> <dave.anglin at bell.net> wrote:
>> On 2018-12-01 4:50 p.m., Jussi Pakkanen wrote:
>>> Thus it would seem that this is not a bug in Meson, but instead in
>>> systemd's build setup as the pie arguments are added by the latter.
>> I agree but Michael doesn't have a clear idea how to fix the issue. 
>> Would the "b_pie" option help?
> I've filed https://github.com/systemd/systemd/pull/11380
>
> Let's hope this get merged upstream.
>
> Dave, can you test attached patch on hppa and report back with the results?
Your fix looks correct to me.  I'll try to test in the next day or two
on hppa.  Does it work on x86?

Regards,
Dave

-- 
John David Anglin  dave.anglin at bell.net


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20190110/8bef44f1/attachment.sig>