Bug#909396: Bug#914543: meson adds both -fPIE and -fPIC options in LTO compiles with gcc-8

[Michael Biebl]

Am 10.01.19 um 16:13 schrieb John David Anglin:
> Hi,
> 
> The merging of PIC/PIE options in gcc-8 was fixed by this change:
> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=267610
> 
> A new build of gcc-8 with the above change was upload yesterday and
> systemd 240-3 built
> successfully on hppa without having to disable LTO:
> https://buildd.debian.org/status/fetch.php?pkg=systemd&arch=alpha&ver=240-3&stamp=1547070353&raw=0


Nice!

> On 2019-01-10 7:09 a.m., Michael Biebl wrote:

>> I've filed https://github.com/systemd/systemd/pull/11380
>>
>> Let's hope this get merged upstream.

It was merged in the mean time.

>> Dave, can you test attached patch on hppa and report back with the results?
> Your fix looks correct to me.  I'll try to test in the next day or two
> on hppa.  Does it work on x86?

I've built the package on amd64 with this patch applied.
I quickly ran hardening-check on the resulting binaries and they all showed
Position Independent Executable: yes
and the system booted successly without any apparent breakage.

I didn't specifically test i386. Do you expect any issues there?

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20190110/5dc881bc/attachment.sig>