[Pkg-sysvinit-devel] Bug#701936: btrfs can't fsck /run/rootdev on boot

[Roger Leigh]

On Wed, Mar 06, 2013 at 09:16:01PM +0100, Daniel Baumann wrote:

> > 2) fsck.btrfs fails to fsck a mounted filesystem
> > 
> > fsck.btrfs won't check a mounted filesystem, even if mounted
> > read-only.  We need to be able to do this, since we are running
> > fsck from the rootfs.  We do this for all other filesystem types.
> 
> the common workaround that e.g. other distributions do is to do this in
> initramfs. probably debian should do that for all filesystems in future too.

What about *right now*, today.  What we "should" do is irrelevant
to the problem right now.  And it's not like doing it in the
initramfs is the only "correct" way to do this.  We've done it
the existing way since forever.  And you broke that.  That's
unacceptable.

> > 3) fsck.btrfs does not support the standard fsck options
> 
> easy fixable, but hasn't much to do with the current remaining problem
> in sid.

Yes, it does.  We use those options.  And that breaks things.

> > 4) fsck.btrfs error codes
> > 
> > I haven't tested this due to point (2) above
> 
> me neither, but that's easy fixable too and hasn't much to do with the
> current remaining problem in sid.

Yes, it does.  If they don't work, then it will again break the
checkroot script.  Please do check this.

> > • systems with a btrfs root filesystem are currently *unbootable*
> >   without using "fastboot" to skip fsck
> 
> *iff* sysvinit is used.

It's the default init system for crying out loud.  You broke
booting with the default init system for all people using a
btrfs rootfs.  And even if it was not the default, it's still
massively broken.  Would breaking booting with systemd or
upstart be any more acceptable?  No, it would not.  End this
ridiculous line of reasoning right now.

> > • even if the checkroot script is "fixed", fsck.btrfs remains
> >   broken and all the unbootable systems remain unbootable
> 
> the current package works fine on systems with systemd (not yet fixed
> points 3 and 4 from above are not breaking it).

That does not solve the problem for the vast majority who are not
using systemd.  Think for a minute about how much breakage you've
just caused.

> > I would recommend that this be immediately reverted in unstable.
> 
> i disagree.

If you are not going to revert this, then please tell me what
you are going to do to fix this, today.  Leaving people's
systems in a broken state is not on.  It must be fixed, and
fixed very quickly.  There are lots of people who can't boot
their computers thanks to this recklessness.

Please, revert it today.


Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800