[Pkg-sysvinit-devel] Bug#794138: reopening 794138

[Helmut Grohne]

On Sun, Nov 12, 2017 at 08:58:44AM +0100, Petter Reinholdtsen wrote:
> I do not understand.  The change is in commit
> 82b9903afb8b5d7d5b5d4e44e375d1eedc000050 in git, which should have been
> included in 0.59-3.2.

I'm sorry and stand corrected. Thank you for insisting. The patch is
applied in git and in unstable.

> Is the collab-maint git not reflecting what was uploaded to the archive?
> As far as I can tell, the patch was applied and included in the upload.

Still, startpar fails to cross build from source. For simplicities sake
I am gonna reuse this bug number for the "new" bug and attach a patch
for that (unless you ask me to close and make a new bug).

The problem now is: Someone added the check target to dh_auto_build for
running tests. Now tests are run even when DEB_BUILD_OPTIONS contains
nocheck. Typically test suites fail during cross compilation with an
expected "Exec format error", which is why cross builds set nocheck.
That's what happens for startpar. Simply removing check from
dh_auto_build is ok, because dh_auto_test (which honours the nocheck
setting) correctly detects the check target and runs it. I hope this is
correct or do we need to pass EXTRACFLAGS and friends to dh_auto_test
now?

I hope you accept my apology and let us move on.

Helmut
-------------- next part --------------
diff --minimal -Nru startpar-0.59/debian/changelog startpar-0.59/debian/changelog
--- startpar-0.59/debian/changelog	2017-11-07 00:17:03.000000000 +0100
+++ startpar-0.59/debian/changelog	2017-11-12 14:00:14.000000000 +0100
@@ -1,3 +1,10 @@
+startpar (0.59-3.3) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Do not run tests when DEB_BUILD_OPTIONS contains nocheck. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sun, 12 Nov 2017 14:00:14 +0100
+
 startpar (0.59-3.2) unstable; urgency=medium
 
   [ Manuel A. Fernandez Montecelo ]
diff --minimal -Nru startpar-0.59/debian/rules startpar-0.59/debian/rules
--- startpar-0.59/debian/rules	2017-11-07 00:17:03.000000000 +0100
+++ startpar-0.59/debian/rules	2017-11-12 14:00:12.000000000 +0100
@@ -21,7 +21,7 @@
 	dh $@
 
 override_dh_auto_build:
-	$(MAKE) EXTRACPPFLAGS="$(CPPFLAGS)" EXTRACFLAGS="$(CFLAGS)" EXTRALDFLAGS="$(LDFLAGS)" CC=$(CC) startpar check
+	$(MAKE) EXTRACPPFLAGS="$(CPPFLAGS)" EXTRACFLAGS="$(CFLAGS)" EXTRALDFLAGS="$(LDFLAGS)" CC=$(CC) startpar
 ifeq ($(DEB_HOST_ARCH_OS),linux)
 	$(MAKE) EXTRACPPFLAGS="$(CPPFLAGS)" EXTRACFLAGS="$(CFLAGS)" EXTRALDFLAGS="$(LDFLAGS)" CC=$(CC) startpar-upstart-inject
 endif