[Pkg-sysvinit-devel] Bug#794138: reopening 794138
pere at hungry.com
Mon Nov 13 05:33:20 UTC 2017
> I'm sorry and stand corrected. Thank you for insisting. The patch is
> applied in git and in unstable.
No worries. Then I know we talk about the same thing. No need to
> The problem now is: Someone added the check target to dh_auto_build
> for running tests. Now tests are run even when DEB_BUILD_OPTIONS
> contains nocheck. Typically test suites fail during cross compilation
> with an expected "Exec format error", which is why cross builds set
> nocheck. That's what happens for startpar. Simply removing check from
> dh_auto_build is ok, because dh_auto_test (which honours the nocheck
> setting) correctly detects the check target and runs it. I hope this
> is correct or do we need to pass EXTRACFLAGS and friends to
> dh_auto_test now?
I added this in 2014, to ensure it was impossible for a autobuilder to
build a package that did not handle the test suite, to avoid ending up
with unbootable systems on some of the less used architectures. I
believe this is an important safety fuse in the build system. As long
as the default build will run the check, I am fine with the change.
> diff --minimal -Nru startpar-0.59/debian/changelog startpar-0.59/debian/changelog
> --- startpar-0.59/debian/changelog 2017-11-07 00:17:03.000000000 +0100
> +++ startpar-0.59/debian/changelog 2017-11-12 14:00:14.000000000 +0100
> @@ -1,3 +1,10 @@
> +startpar (0.59-3.3) UNRELEASED; urgency=medium
> + * Non-maintainer upload.
> + * Do not run tests when DEB_BUILD_OPTIONS contains nocheck. (Closes: #-1)
> + -- Helmut Grohne <helmut at subdivi.de> Sun, 12 Nov 2017 14:00:14 +0100
> startpar (0.59-3.2) unstable; urgency=medium
If dh_auto_test now run 'make check' automatically, can you figure out
which version of it started doing this, and update the build
dependencies, to ensure it still is impossible to build the source
without checking that it work?
More information about the Pkg-sysvinit-devel