[Pkg-tcltk-devel] tDOM review & sponsorship

[Sergei Golovan]

On 5/28/08, Stefan Sobernig <stefan.sobernig at wu-wien.ac.at> wrote:
>
> I'd appreciate any valuable review, irrespective of whether it takes
>  the upcoming weekend to get Sergei's final go ...

I have a few comments (most of them I've fixed in SVN, but take a look
at them, they might be not very nice).

1) I don't think that storing an original tarball at a wiki is a good
idea. I think that it's better to fetch it from CVS directly (see
changes in debian/rules and debian/checkout - I don't know how to
checkout from CVS without a tool like expect).

2) I think that it's better to merge last two changelog entries.

3) I think that there's no reason to move tdom.tcl to /usr/share. If
tDOM were a Tcl-only package then it would go to /usr/share naturally.

4) It's better to add suffix '3tcl' to manual pages (or maybe even
'3tdom'?) instead of '3' to lower the probability of file name
conflict with other packages.

5) debian/changelog misses two first entries (for 0.7.8-1 and 0.7.8-2)

6) Both tdom and tdom-dev packages have the same homepage, so it's
natural to move Homepage field to a source package.

7) (I haven't fixed this) A long description of tdom-dev is too
sparse. And description of tdom package isn't always correct (for
example, it says about 'the newest version of Expat' but it uses
system-wide Expat).

8) Last two people in Uploaders list share one email address. Isn't it
a bit strange?

Please, make the description more clear and look if you can accept my changes.

-- 
Sergei Golovan