[Pkg-tcltk-devel] tDOM review & sponsorship
Stefan Sobernig
stefan.sobernig at wu-wien.ac.at
Sun Jun 1 16:00:47 UTC 2008
Sergei,
Thanks for the thorough review + contributing fixes directly. This is
appreciated mucho más. Especially, thanks for taking time ... :)
In short, I basically agree to all your kindly committed changes. I
added a slight remark whether expect is really necessary (a simplifying
patch is provided). I changed the long documentation parts in
debian/control. I also had to commit a minor fix to the sed logic on man
pages.
> 1) I don't think that storing an original tarball at a wiki is a good
> idea. I think that it's better to fetch it from CVS directly (see
> changes in debian/rules and debian/checkout - I don't know how to
> checkout from CVS without a tool like expect).
As for wiki-hosting, i found it to be more reliable than direct cvs
access (in history, tdom.org had some availability issues). but,
honestly, i don't really care, i have no clear preferences in either
direction. so cvs is fine with me.
as for expect: i am wondering whether expect is not a slight overkill
here. i guess i would be fine to call cvs directly, as username
and password may be passed directly in the pserver scheme. an empty
password for a :pserver:anonymous scheme is automatically implied by cvs
protocol. besides, using expect would mean to add another dependency to
the source package, wouldn't it?
Btw. do we need to add a cvs build-dep when using it in the
get-orig-source target?
I attached a patched, expect-free version of your get-orig-source-target
which I tested and should be fine, to the best of my knowledge. but, I
put full trust in your judgement. If you say expect is needed for some
reason I might have missed, i am perfectly fine with it.
>
> 2) I think that it's better to merge last two changelog entries.
ok. I am fine with it.
>
> 3) I think that there's no reason to move tdom.tcl to /usr/share. If
> tDOM were a Tcl-only package then it would go to /usr/share naturally.
well, yes. again, i thought that this would be in line with your policy.
I don't know where to draw the line. tdom.tcl is certainly a bit
different as it serves as initializer and bootstrap script which is
arch-indep, by definition. but, again, as it is a matter of taste. let's
leave it where it was!
>
> 4) It's better to add suffix '3tcl' to manual pages (or maybe even
> '3tdom'?) instead of '3' to lower the probability of file name
> conflict with other packages.
ok.
>
> 5) debian/changelog misses two first entries (for 0.7.8-1 and 0.7.8-2)
ok. I hadn't checked older changelog entries, dating back to the last
maintainer. certainly a neat clean-up.
>
> 6) Both tdom and tdom-dev packages have the same homepage, so it's
> natural to move Homepage field to a source package.
ok.
>
> 7) (I haven't fixed this) A long description of tdom-dev is too
> sparse. And description of tdom package isn't always correct (for
> example, it says about 'the newest version of Expat' but it uses
> system-wide Expat).
>
> 8) Last two people in Uploaders list share one email address. Isn't it
> a bit strange?
ok. I added one for avni, so it makes an email address per uploader.
>
> Please, make the description more clear and look if you can accept my changes.
>
I reviewed them, made the tdom one more generic & shorter, and expanded
the tdom-dev one.
Let me know whether I missed anything!
Thanks again,
//stefan
--
Stefan Sobernig
Institute for Information Systems and New Media
Vienna University of Economics
Augasse 2-6
A - 1090 Vienna
`- +43 - 1 - 31336 - 4878 [phone]
`- +43 - 1 - 31336 - 746 [fax]
`- stefan.sobernig at wu-wien.ac.at <mailto:stefan.sobernig at wu-wien.ac.at>
`- ss at thinkersfoot.net <mailto:ss at thinkersfoot.net>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: get-orig-source-simple.patch
Url: http://lists.alioth.debian.org/pipermail/pkg-tcltk-devel/attachments/20080601/7e330750/attachment.txt
More information about the Pkg-tcltk-devel
mailing list