[Pkg-tcltk-devel] tDOM review & sponsorship

[Sergei Golovan]

On 6/1/08, Stefan Sobernig <stefan.sobernig at wu-wien.ac.at> wrote:
> Sergei,
>
>  Thanks for the thorough review + contributing fixes directly. This is
> appreciated mucho más. Especially, thanks for taking time ... :)
>
>  In short, I basically agree to all your kindly committed changes. I added a
> slight remark whether expect is really necessary (a simplifying patch is

You're right. Simply calling cvs is sufficient. For unknown reason I
thought that login is necessary.

> provided). I changed the long documentation parts in debian/control. I also
> had to commit a minor fix to the sed logic on man pages.
>
>
> > 1) I don't think that storing an original tarball at a wiki is a good
> > idea. I think that it's better to fetch it from CVS directly (see
> > changes in debian/rules and debian/checkout - I don't know how to
> > checkout from CVS without a tool like expect).
> >
>
>  As for wiki-hosting, i found it to be more reliable than direct cvs
>  access (in history, tdom.org had some availability issues). but,
>  honestly, i don't really care, i have no clear preferences in either
>  direction. so cvs is fine with me.

OK

>
>  Btw. do we need to add a cvs build-dep when using it in the get-orig-source
> target?

No. cvs isn't used at build time. Though adding a note about cvs to
debian/copyright would be nice.

> >
> > 3) I think that there's no reason to move tdom.tcl to /usr/share. If
> > tDOM were a Tcl-only package then it would go to /usr/share naturally.
> >
>
>  well, yes. again, i thought that this would be in line with your policy.
>  I don't know where to draw the line. tdom.tcl is certainly a bit different
> as it serves as initializer and bootstrap script which is arch-indep, by
> definition. but, again, as it is a matter of taste. let's leave it where it
> was!

One of the reasons we put packages to /usr/lib/tcltk and
/usr/share/tcltk is to make directories list where to search for
pkgIndex.tcl as short as possible. So, creating two directories
instead of one isn't a good idea.

> >
> > Please, make the description more clear and look if you can accept my
> changes.
> >
> >
>
>  I reviewed them, made the tdom one more generic & shorter, and expanded the
> tdom-dev one.

Looks fine to me. If you don't have to add something else, I'll upload
the package tonight.

-- 
Sergei Golovan