[Pkg-tigervnc-devel] Request to Join Project TigerVNC package for Debian from Ola Lundqvist (opal)

Ola Lundqvist ola.lundqvist at gmail.com
Mon Jan 25 22:23:07 UTC 2016


Hi

I have started to review the control file. I have attached a change
proposal based on my experience with vnc packaging from before.

I have also included the patch here with comments why I would like to do
the changes. The comment is below the patch section.


diff --git a/debian/control b/debian/control
> index d6abb8b..6b39817 100644
> --- a/debian/control
> +++ b/debian/control

@@ -5,7 +5,8 @@ Maintainer: TigerVNC Packaging Team <
> pkg-tigervnc-devel at lists.alioth.debian.org>
>  Uploaders:
>   Joachim Falk <joachim.falk at gmx.de>,
>   Mike Gabriel <mike.gabriel at das-netzwerkteam.de>,
> - Yaroslav Halchenko <debian at onerussian.com>
> + Yaroslav Halchenko <debian at onerussian.com>,
> + Ola Lundqvist <opal at debian.org>
>  # all the Build-Depends up to x11proto-xf86-dri-dev are for the normal
> Xorg
>  # server, and common dependencies for the DIX.
>  # x11proto-xf86dri-dev and libdrm-dev are for DRI support for the Xorg
> server.


Just adding myself.

@@ -112,14 +113,14 @@ Depends:
>  Conflicts:
>   tigervnc-server (<< 1.1.90),
>   tigervnc-viewer (<< 1.1.90)
> -Description: Virtual network computing; Common software needed by clients
> and servers
> +Description: Virtual network computing; Common software needed by servers
>   VNC stands for Virtual Network Computing. It is, in essence, a remote
>   display system which allows you to view a computing `desktop' environment
>   not only on the machine where it is running, but from anywhere on the
>   Internet and from a wide variety of machine architectures.
>   .
>   It is implemented in a client/server model. This package provides the
> common
> - software for both client and server.
> + software for servers.
>
>  Package: tigervnc-scraping-server
>  Architecture: any


The common tools are not needed by the viewer. The vncconfig tool is just
to manage a Xvnc (or X with extension) server and the vncpasswd command is
also just needed on the server side. Or am I missing something here?

I guess this packaging practice is a leftover from where tightvnc and vnc4
actually had a common package. Now the need arise again but just because we
provide serveral server alternatives.

@@ -131,7 +132,6 @@ Depends:
>   ${shlibs:Depends},
>   ${misc:Depends},
>  Recommends: libgl1-mesa-dri (>= 7.1~rc1)
> -Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable
>  Provides:
>   vnc-server,
>   ${videoabi},


I do not think the scraping server need fonts on its own, or?

The below patch section is actually commented within the section itself as
there are so many things that I propose.

@@ -160,13 +160,15 @@ Depends:
>   keyboard-configuration [linux-any kfreebsd-any],
>   udev (>= 149) [linux-any],
>   tigervnc-common,
> + xauth,
>   ${shlibs:Depends},
>   ${misc:Depends},
>   ${perl:Depends}


The vncserver command actually depend on xauth so it should be here. I
could accept a recommends as it is just the vncserver command that need it.
The Xvnc command do not. However a dependency here is not really a problem
as one would expect it to be there.

-Recommends: libgl1-mesa-dri (>= 7.1~rc1)
> +Recommends: libgl1-mesa-dri (>= 7.1~rc1), xfonts-base, x11-xserver-utils
>  Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable


xfonts-base is just to recommend a standard set of fonts. Previous vnc
packages have had it but maybe it is not needed.

The recommendation on x11-server-utils is to get tools like xrandr, xauth
and the like. They are quite useful... But maybe the contents have changed
too many times since first added to the vnc suite.

 Provides:
>   vnc-server,
> + xserver,
>   ${videoabi},
>   ${inputabi}
>  Replaces: tigervnc-server (<< 1.1.90)


I think the vncserver package should declare that it is its own xserver.
Not sure if this break some rule though. Tightvnc and vnc4 so so and I have
not got any complaints about this.

@@ -193,7 +195,7 @@ Depends:
>   tigervnc-common,
>   ${shlibs:Depends},
>   ${misc:Depends},
> -Recommends: libgl1-mesa-dri (>= 7.1~rc1)
> +Recommends: libgl1-mesa-dri (>= 7.1~rc1), xfonts-base, x11-xserver-utils
>  Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable
>  Provides:
>   vnc-server,


Same comment as for the standalone server. Extension have same kind of
need. However it is not its own xserver so it should not provide it.

@@ -215,11 +217,10 @@ Package: tigervnc-viewer
>  Architecture: any
>  Depends:
>   xserver-common (>= 2:1.7.7),
> - tigervnc-common,
>   ${shlibs:Depends},
>   ${misc:Depends},


The viewer do not need vncpasswd nor vncconfig. So I think we can remove
it. If you know a use-case when it should be needed then please let me know.

 Provides:
> - vnc-viewer
> + vncviewer, vnc-viewer
>  Description: Virtual network computing client software for X
>   VNC stands for Virtual Network Computing. It is, in essence, a remote
>   display system which allows you to view a computing `desktop' environment


Historically the vnc4 and tightvnc packages have provided this vncviewer
one too. However that is because we had a realvnc/vnc/vnc3 package many
years ago that had this alias. Maybe we do not need to support transition
cases that dates back 8 years or so... :-) I added it anyway.

What do you think?

// Ola



On Mon, Jan 25, 2016 at 10:08 PM, Ola Lundqvist <ola.lundqvist at gmail.com>
wrote:

> Hi
>
> Please upload anyway. I'll build on sid too but would like to do initial
> tests on stable.
>
> / Ola
>
> Sent from a phone
> Den 25 jan 2016 21:56 skrev "Yaroslav Halchenko" <debian at onerussian.com>:
>
>>
>> On Mon, 25 Jan 2016, Ola Lundqvist wrote:
>>
>> >    Thanks. I'll focus on the build and testing then. Do you happen to
>> have a
>> >    backport of flvtk? I guess not but best to ask. :-)
>>
>> Well -- I do BUT non-official lazy backport and not sure if it wouldn't
>> bring
>> havoc to other tools. at least that prev version caused  some FTBFS in
>> stretch
>> when last I have tried then (see below). but if you like I could upload
>> it to
>> e.g. -devel of the neurodebian repository.  Although still -- better to
>> build/make sure it works against sid at this point ;)
>>
>> % cat 1.3.3-2/fltk1.3_1.3.3-2_amd64.testrdepends.nd+debian-stretch.summary
>>
>> Testing builds against fltk1.3_1.3.3-2.dsc
>> ax25-tools_0.0.10-rc2+cvs20120204-4.dsc        ok      ok
>> bist_0.5.2-1.dsc                               ok      ok
>> codfis_0.4.7-2.dsc                             ok      ok
>> csound_6.05~dfsg1-2.dsc                        ok      ok
>> dillo_3.0.5-1.dsc                              ok      ok
>> eureka_1.07-1.dsc                              ok      ok
>> fgrun_3.4.0.final-1.dsc                        ok   FAILED
>> /backup/neurodebian/deb/builds/fltk1.3/1.3.3-2/fltk1.3_1.3.3-2_amd64.testrdepends.nd+debian-stretch/srcs/new/fgrun_3.4.0.final-1_amd64.build
>> flamp_2.2.02-1.dsc                             ok      ok
>> fldigi_3.22.10-1.dsc                           ok      ok
>> flmsg_2.0.10-1.dsc                             ok      ok
>> flpsed_0.7.3-1.dsc                             ok      ok
>> flrig_1.3.22-1.dsc                             ok      ok
>> flwrap_1.3.4-2.1.dsc                           ok      ok
>> freecad_0.14.3702+dfsg-3.dsc                   ok      ok
>> freefem++_3.37.1-1.dsc                         ok      ok
>> giada_0.10.0~dfsg1-1.dsc                       ok      ok
>> gmsh_2.9.3+dfsg1-1.dsc                         ok      ok
>> goplay_0.9.dsc                                 ok      ok
>> horgand_1.14-5.dsc                             ok      ok
>> imview_1.1.9c-12.dsc                           ok      ok
>> mathgl_2.2.2.1-3.dsc                        FAILED  FAILED
>> /backup/neurodebian/deb/builds/fltk1.3/1.3.3-2/fltk1.3_1.3.3-2_amd64.testrdepends.nd+debian-stretch/srcs/new/mathgl_2.2.2.1-3_amd64.build
>> obdgpslogger_0.16-1.2.dsc                      ok      ok
>> octave_3.8.2-4.1.dsc                           ok      ok
>> paulstretch_2.2-2-3.dsc                        ok      ok
>> relion_1.3+dfsg-2.dsc                          ok      ok
>> seaview_4.5.4.4-1.dsc                          ok      ok
>> trovacap_0.2.2-1.dsc                           ok      ok
>> tuxpaint-config_0.0.13-1.dsc                   ok      ok
>> xpp_1.5-cvs20081009-1.dsc                      ok      ok
>> yoshimi_1.3.5.1-2.dsc                          ok   FAILED
>> /backup/neurodebian/deb/builds/fltk1.3/1.3.3-2/fltk1.3_1.3.3-2_amd64.testrdepends.nd+debian-stretch/srcs/new/yoshimi_1.3.5.1-2_amd64.build
>> zynaddsubfx_2.4.3-6.dsc                        ok      ok
>>
>>
>> >    I guessed that was the issue too. It did not work when I bumped back
>> the
>> >    required number one number.
>> >    The problem is that if I'd like to test on stable if possible. But
>> if that
>> >    do not really work, then I'll arrange some testing area.
>> >    // Ola
>> >    On Mon, Jan 25, 2016 at 9:42 PM, Yaroslav Halchenko <yoh at debian.org>
>> >    wrote:
>>
>> >      On Mon, 25 Jan 2016, Ola Lundqvist wrote:
>>
>> >      >A  A  A  primary problem was inclusion of xorg sources etc.AA
>> Since
>> >      they we moved
>> >      >A  A  The interesting this is that vnc4 and tightvnc are still
>> allowed
>> >      to be
>> >      >A  A  there. They have exactly the same problem... :-/
>>
>> >      ;-)
>> >      >A  A  A  away from that and there is now xorg-server-source so we
>> >      should all be
>> >      >A  A  A  kosher and indeed aim to reupload.AA  For that we need to
>> >      finish updating
>> >      >A  A  A  it for 1.5.0 tigervnc or even jump over to recently
>> released
>> >      >A  A  A  1.6.0; and then re-review all the copyright etc
>>
>> >      >A  A  A  But otherwise we indeed should be close to be ready ;)
>>
>> >      >A  A  Great. What do you want me to focus on?
>> >      >A  A  - Review licenses?
>> >      >A  A  - Update to latest versions? (I still struggle to build the
>> >      current
>> >      >A  A  version as I'm still running stable I guess)
>> >      >A  A  - or something else?
>>
>> >      building/testing latest version I guessA  would be the most
>> >      valuable, especially with your expertise.
>>
>> >      you would need stretch/sid due to necessity of fresh flvtk IIRC.
>> >      (s)chroot
>> >      might be sufficient ;)
>> --
>> Yaroslav O. Halchenko
>> Center for Open Neuroscience     http://centerforopenneuroscience.org
>> Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
>> Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
>> WWW:   http://www.linkedin.com/in/yarik
>>
>> _______________________________________________
>> Pkg-tigervnc-devel mailing list
>> Pkg-tigervnc-devel at lists.alioth.debian.org
>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-tigervnc-devel
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-tigervnc-devel/attachments/20160125/c7f81584/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: proposal.patch
Type: application/octet-stream
Size: 2786 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-tigervnc-devel/attachments/20160125/c7f81584/attachment-0001.obj>


More information about the Pkg-tigervnc-devel mailing list