[Pkg-tigervnc-devel] Request to Join Project TigerVNC package for Debian from Ola Lundqvist (opal)

[Yaroslav Halchenko]

On Mon, 25 Jan 2016, Ola Lundqvist wrote:

> I have started to review the control file. I have attached a change
> proposal based on my experience with vnc packaging from before.

we could try continuing reviewing via email, or should we may be push it
also on github and then use PR/comments mechanism?

otherwise -- we just usually trusted each other's judgement so far ;)

some comments below

> @@ -112,14 +113,14 @@ Depends:
> >  Conflicts:
> >   tigervnc-server (<< 1.1.90),
> >   tigervnc-viewer (<< 1.1.90)
> > -Description: Virtual network computing; Common software needed by clients
> > and servers
> > +Description: Virtual network computing; Common software needed by servers
> >   VNC stands for Virtual Network Computing. It is, in essence, a remote
> >   display system which allows you to view a computing `desktop' environment
> >   not only on the machine where it is running, but from anywhere on the
> >   Internet and from a wide variety of machine architectures.
> >   .
> >   It is implemented in a client/server model. This package provides the
> > common
> > - software for both client and server.
> > + software for servers.

> >  Package: tigervnc-scraping-server
> >  Architecture: any


> The common tools are not needed by the viewer. The vncconfig tool is just
> to manage a Xvnc (or X with extension) server and the vncpasswd command is
> also just needed on the server side. Or am I missing something here?

that may be they could be used by both server packages?  

so we may be should dump it from viewer package depends indeed

> I guess this packaging practice is a leftover from where tightvnc and vnc4
> actually had a common package. Now the need arise again but just because we
> provide serveral server alternatives.

> @@ -131,7 +132,6 @@ Depends:
> >   ${shlibs:Depends},
> >   ${misc:Depends},
> >  Recommends: libgl1-mesa-dri (>= 7.1~rc1)
> > -Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable
> >  Provides:
> >   vnc-server,
> >   ${videoabi},

> I do not think the scraping server need fonts on its own, or?

to say the truth -- don't know for sure.  logically -- indeed it
shouldn't need them

> The below patch section is actually commented within the section itself as
> there are so many things that I propose.

> @@ -160,13 +160,15 @@ Depends:
> >   keyboard-configuration [linux-any kfreebsd-any],
> >   udev (>= 149) [linux-any],
> >   tigervnc-common,
> > + xauth,
> >   ${shlibs:Depends},
> >   ${misc:Depends},
> >   ${perl:Depends}


> The vncserver command actually depend on xauth so it should be here. I
> could accept a recommends as it is just the vncserver command that need it.
> The Xvnc command do not. However a dependency here is not really a problem
> as one would expect it to be there.

ok

> -Recommends: libgl1-mesa-dri (>= 7.1~rc1)
> > +Recommends: libgl1-mesa-dri (>= 7.1~rc1), xfonts-base, x11-xserver-utils
> >  Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable


> xfonts-base is just to recommend a standard set of fonts. Previous vnc
> packages have had it but maybe it is not needed.

IDK (I don't know or I don't care) ;-)

> The recommendation on x11-server-utils is to get tools like xrandr, xauth
> and the like. They are quite useful... But maybe the contents have changed
> too many times since first added to the vnc suite.

ok

>  Provides:
> >   vnc-server,
> > + xserver,
> >   ${videoabi},
> >   ${inputabi}
> >  Replaces: tigervnc-server (<< 1.1.90)


> I think the vncserver package should declare that it is its own xserver.
> Not sure if this break some rule though. Tightvnc and vnc4 so so and I have
> not got any complaints about this.

ok

> @@ -193,7 +195,7 @@ Depends:
> >   tigervnc-common,
> >   ${shlibs:Depends},
> >   ${misc:Depends},
> > -Recommends: libgl1-mesa-dri (>= 7.1~rc1)
> > +Recommends: libgl1-mesa-dri (>= 7.1~rc1), xfonts-base, x11-xserver-utils
> >  Suggests: xfonts-100dpi | xfonts-75dpi, xfonts-scalable
> >  Provides:
> >   vnc-server,


> Same comment as for the standalone server. Extension have same kind of
> need. However it is not its own xserver so it should not provide it.

> @@ -215,11 +217,10 @@ Package: tigervnc-viewer
> >  Architecture: any
> >  Depends:
> >   xserver-common (>= 2:1.7.7),
> > - tigervnc-common,
> >   ${shlibs:Depends},
> >   ${misc:Depends},


> The viewer do not need vncpasswd nor vncconfig. So I think we can remove
> it. If you know a use-case when it should be needed then please let me know.

ok

>  Provides:
> > - vnc-viewer
> > + vncviewer, vnc-viewer
> >  Description: Virtual network computing client software for X
> >   VNC stands for Virtual Network Computing. It is, in essence, a remote
> >   display system which allows you to view a computing `desktop' environment


> Historically the vnc4 and tightvnc packages have provided this vncviewer
> one too. However that is because we had a realvnc/vnc/vnc3 package many
> years ago that had this alias. Maybe we do not need to support transition
> cases that dates back 8 years or so... :-) I added it anyway.

> What do you think?

ok
;-)

-- 
Yaroslav O. Halchenko
Center for Open Neuroscience     http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik